Skip to content

[Validator] Fix of the description of the mime type message option #16684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2022
Merged

[Validator] Fix of the description of the mime type message option #16684

merged 1 commit into from
Apr 26, 2022

Conversation

mdoutreluingne
Copy link
Contributor

@mdoutreluingne mdoutreluingne commented Apr 4, 2022 •
edited
Loading

In this PR, I corrected the mistake I made here.

I used the table of parameters of the File constraint to explain the different parameters in the Image constraint.

Can you do a review please?

@fancyweb ready for review :)

@mdoutreluingne mdoutreluingne requested a review from xabbuh as a code owner April 4, 2022 09:02
@carsonbot carsonbot added this to the 6.1 milestone Apr 4, 2022
@mdoutreluingne mdoutreluingne changed the title [Validator] Fix of the description of the mime type option [Validator] Fix of the description of the mime type message option Apr 4, 2022
@mdoutreluingne mdoutreluingne changed the title [Validator] Fix of the description of the mime type message option [WIP][Validator] Fix of the description of the mime type message option Apr 4, 2022
@carsonbot carsonbot changed the title [WIP][Validator] Fix of the description of the mime type message option [Validator] [WIP] Fix of the description of the mime type message option Apr 13, 2022
@mdoutreluingne mdoutreluingne changed the title [Validator] [WIP] Fix of the description of the mime type message option [Validator] [WCM] Fix of the description of the mime type message option Apr 13, 2022
@mdoutreluingne mdoutreluingne changed the title [Validator] [WCM] Fix of the description of the mime type message option [Validator] Fix of the description of the mime type message option Apr 16, 2022
@javiereguiluz javiereguiluz merged commit cf08882 into symfony:6.1 Apr 26, 2022
@javiereguiluz
Copy link
Member

Maxime, thanks a lot for fixing this.

@mdoutreluingne mdoutreluingne deleted the fix-mime-types-message-image branch April 30, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

+1 more reviewer

@fancyweb fancyweb fancyweb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@mdoutreluingne @javiereguiluz @xabbuh @fancyweb @carsonbot